Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: docs for dwh cost estimates and savings #3554

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

caiters
Copy link
Contributor

@caiters caiters commented Dec 21, 2024

No description provided.


Cost savings are broken up into three main categories:

- **Prevented Reruns**: If SQLMesh has already run an execution for a change in one environment, we won't need to rerun it in another environment (such as when a model change is backfilled on a development environment and then applied to prod)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels the virtual environments bullet is describing this same functionality

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the two are indeed similar so it makes sense that it feels the same, but maybe there's a better way to differentiate? - I can double check with @crericha that this language is correct

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the rewording you did, after Trey made his comment, addressed the concern and the two classifications sound distinct.

Copy link
Contributor

@treysp treysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Made a PR against this branch so you can see my edits. #3564

@treysp treysp force-pushed the docs/costs-savings branch from 3312fb8 to ee8a5b8 Compare January 6, 2025 21:39
docs/cloud/features/costs_savings.md Outdated Show resolved Hide resolved
docs/cloud/features/costs_savings.md Outdated Show resolved Hide resolved
docs/cloud/features/costs_savings.md Show resolved Hide resolved
docs/cloud/features/costs_savings.md Show resolved Hide resolved
docs/cloud/features/costs_savings.md Outdated Show resolved Hide resolved
@caiters caiters requested a review from sungchun12 January 9, 2025 20:04

\*These are the current default costs as of January 2025, and will be updated in Tobiko Cloud as warehouse cost defaults change.

## Where to find cost and savings estimates information
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest introducing savings before where to find them.


## Where to find cost and savings estimates information

Estimated costs and savings are displayed on the Tobiko Cloud homepage, production environment page, runs and plans pages, and individual model pages.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is the first time estimated is included. Should we add a paragraph to the first section with the disclaimer that it may not 100% match, but is based on the data retrieved from the datawarehouse itself? And then remove estimated from here and elsewhere.


## Savings Categories

When calculating your data warehouse costs, Tobiko Cloud also estimates how much money it saved you!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: who is it isn't clear here. It could be the dwh or tcloud.


When calculating your data warehouse costs, Tobiko Cloud also estimates how much money it saved you!

Cost savings are broken up into three main categories:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are three types of cost savings tracked by Tobiko Cloud:


Cost savings are broken up into three main categories:

- **Prevented Reruns**: If SQLMesh has already run an execution for a change in one environment, we won't need to rerun it in another environment (such as when a model change is backfilled on a development environment and then applied to prod).
Copy link
Contributor

@crericha crericha Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If SQLMesh has already executed the model for the interval(s) requested, it knows that it doesn't need to execute the interval(s) again (such as...)

Cost savings are broken up into three main categories:

- **Prevented Reruns**: If SQLMesh has already run an execution for a change in one environment, we won't need to rerun it in another environment (such as when a model change is backfilled on a development environment and then applied to prod).
- **Unaffected Downstream**: Because SQLMesh understands SQL, we know if a downstream model is not affected by an upstream change and can avoid re-execution.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can detect detect when a downstream model is not affected by an upstream change and avoid an re-execution that we know would produce the same data


### Where to find cost savings information

Cost savings are shown in most of the places data warehouse costs are displayed. You can find how much Tobiko Cloud has saved you by viewing the homepage, production environment page, or individual model pages.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not show on the plan page yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants